Add a span for OpenTelemetry to Prometheus push request conversion in distributors #5539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
reviewed
Jul 19, 2023
56quarters
approved these changes
Jul 19, 2023
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
…ecode-time-in-distributor-tracing # Conflicts: # CHANGELOG.md
charleskorn
deleted the
charleskorn/include-decode-time-in-distributor-tracing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR improves the observability of OTLP write requests in distributors.
We've seen instances where the conversion to Prometheus write request format can take up to a second (which inspired #5531). This PR adds a span with more information so we can more easily diagnose cases like these in the future.
Which issue(s) this PR fixes or relates to
Relates to #5531
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]